-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] feat: override start & bundle commands #537
Conversation
🦋 Changeset detectedLatest commit: 67cf989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think it'd be valuable to add note to docs 👍
For future it'd good to also somehow inform user about options that are not available, because right now we're explicitly using the same options as Metro's repack/packages/repack/commands.js Lines 55 to 56 in 270ca1a
|
agree 💯, we need to address this in a separate PR and most likely after v4 release |
* feat: override metro commands by default * feat: update types for commands * test: add basic tests to TesterApp suite * chore: add changeset * chore: adjust changeset
* feat: override metro commands by default * feat: update types for commands * test: add basic tests to TesterApp suite * chore: add changeset * chore: adjust changeset
Summary
Closes #93
Closes #487
Override
start
&bundle
commands from CLI.For maximum compatibility, instead of replacing
webpack-start
andwebpack-bundle
commands, the overrides were added on top of old commands. This results in following behaviour:It's possible to opt out of overrides by simply filtering out commands in
react-native.config.js
:This also solves the issue with launching metro dev server when running
react-native run-ios
orreact-native run-android
- Re.Pack dev server will be launched insteadTest plan