Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure file lists in manifests are sorted #265

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

justusburger
Copy link
Contributor

Summary

After building an app, the manifest ({chunk}.json) files contain file lists in the files and auxiliaryFiles fields. These file lists are not sorted, causing the total "output" of a build to change, even if the source did not change.

This PR adds sorting to fix this.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: d9ca6f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/repack Minor
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justusburger
Copy link
Contributor Author

Happy for you to decide if you want to bump the version.

@mikeduminy
Copy link
Contributor

It'd also be great to get this in v2 🙏

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RafikiTiki RafikiTiki merged commit a288e1a into callstack:main Oct 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants