Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use global instead of this when evaluating HMR update #33

Merged
merged 1 commit into from
May 25, 2021
Merged

fix: use global instead of this when evaluating HMR update #33

merged 1 commit into from
May 25, 2021

Conversation

zamotany
Copy link
Contributor

Summary

Fixes #29

Test plan

  1. Run the app with development server.
  2. Make change to the source code that would trigger HMR update.
  3. The update should be successfully applied.

@zamotany zamotany merged commit 525b696 into main May 25, 2021
@zamotany zamotany deleted the fix/hmr-wrong-globals branch May 25, 2021 10:08
@vlak-koder vlak-koder mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuGuohui NiuGuohui NiuGuohui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMR has some Error!
2 participants
@zamotany @NiuGuohui