Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New arch migration #495

Merged
merged 8 commits into from
Feb 1, 2024
Merged

New arch migration #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd6c28b
TS spec + android old arch
Jan 31, 2024
ffe4029
android new arch
Jan 31, 2024
93163fc
ios support
Jan 31, 2024
651dec1
fix tests
Feb 1, 2024
aeff6e6
change needsEagerInit to true
Feb 1, 2024
e4baf83
add early return
Feb 1, 2024
91631de
fix comment
Feb 1, 2024
985d6e5
chore: add changeset
jbroma Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/warm-numbers-doubt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@callstack/repack": major
"testerapp": patch
---

Support for New Architecture
174 changes: 149 additions & 25 deletions packages/TesterApp/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,33 @@
PODS:
- boost (1.83.0)
- callstack-repack (3.7.0):
- glog
- hermes-engine
- JWTDecode (~> 3.0.0)
- RCT-Folly (= 2022.05.16.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- SwiftyRSA (~> 1.7)
- Yoga
- DoubleConversion (1.1.6)
- FBLazyVector (0.73.2)
- FBReactNativeSpec (0.73.2):
- RCT-Folly (= 2022.05.16.00)
- RCTRequired (= 0.73.2)
- RCTTypeSafety (= 0.73.2)
- React-Core (= 0.73.2)
- React-jsi (= 0.73.2)
- ReactCommon/turbomodule/core (= 0.73.2)
- fmt (6.2.1)
- glog (0.3.5)
- hermes-engine (0.73.0):
- hermes-engine/Pre-built (= 0.73.0)
- hermes-engine/Pre-built (0.73.0)
- hermes-engine (0.73.2):
- hermes-engine/Pre-built (= 0.73.2)
- hermes-engine/Pre-built (0.73.2)
- JWTDecode (3.0.1)
- libevent (2.1.12)
- RCT-Folly (2022.05.16.00):
Expand Down Expand Up @@ -63,17 +73,21 @@ PODS:
- React-callinvoker (0.73.2)
- React-Codegen (0.73.2):
- DoubleConversion
- FBReactNativeSpec
- glog
- hermes-engine
- RCT-Folly
- RCTRequired
- RCTTypeSafety
- React-Core
- React-debug
- React-Fabric
- React-FabricImage
- React-graphics
- React-jsi
- React-jsiexecutor
- React-NativeModulesApple
- React-rncore
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- React-Core (0.73.2):
Expand Down Expand Up @@ -886,6 +900,8 @@ PODS:
- React-jsi (= 0.73.2)
- React-perflogger (= 0.73.2)
- React-jsinspector (0.73.2)
- React-jsitracing (0.73.2):
- React-jsi
- React-logger (0.73.2):
- glog
- React-Mapbuffer (0.73.2):
Expand Down Expand Up @@ -919,13 +935,21 @@ PODS:
- RCTTypeSafety
- React-Core
- React-CoreModules
- React-debug
- React-Fabric
- React-graphics
- React-hermes
- React-nativeconfig
- React-NativeModulesApple
- React-RCTFabric
- React-RCTImage
- React-RCTNetwork
- React-rendererdebug
- React-RuntimeApple
- React-RuntimeCore
- React-RuntimeHermes
- React-runtimescheduler
- React-utils
- ReactCommon
- React-RCTBlob (0.73.2):
- hermes-engine
Expand Down Expand Up @@ -1003,8 +1027,42 @@ PODS:
- RCT-Folly (= 2022.05.16.00)
- React-debug
- React-rncore (0.73.2)
- React-RuntimeApple (0.73.2):
- hermes-engine
- RCT-Folly/Fabric (= 2022.05.16.00)
- React-callinvoker
- React-Core/Default
- React-CoreModules
- React-cxxreact
- React-jserrorhandler
- React-jsi
- React-jsiexecutor
- React-Mapbuffer
- React-NativeModulesApple
- React-RCTFabric
- React-RuntimeCore
- React-runtimeexecutor
- React-RuntimeHermes
- React-utils
- React-RuntimeCore (0.73.2):
- glog
- hermes-engine
- RCT-Folly/Fabric (= 2022.05.16.00)
- React-cxxreact
- React-jserrorhandler
- React-jsi
- React-jsiexecutor
- React-runtimeexecutor
- React-runtimescheduler
- React-runtimeexecutor (0.73.2):
- React-jsi (= 0.73.2)
- React-RuntimeHermes (0.73.2):
- hermes-engine
- RCT-Folly/Fabric (= 2022.05.16.00)
- React-jsi
- React-jsitracing
- React-nativeconfig
- React-utils
- React-runtimescheduler (0.73.2):
- glog
- hermes-engine
Expand Down Expand Up @@ -1059,9 +1117,63 @@ PODS:
- React-logger (= 0.73.2)
- React-perflogger (= 0.73.2)
- RNCAsyncStorage (1.21.0):
- glog
- hermes-engine
- RCT-Folly (= 2022.05.16.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNSVG (14.1.0):
- glog
- hermes-engine
- RCT-Folly (= 2022.05.16.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- RNSVG (13.8.0):
- React-debug
- React-Fabric
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- RNSVG/common (= 14.1.0)
- Yoga
- RNSVG/common (14.1.0):
- glog
- hermes-engine
- RCT-Folly (= 2022.05.16.00)
- RCTRequired
- RCTTypeSafety
- React-Codegen
- React-Core
- React-debug
- React-Fabric
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- SocketRocket (0.6.1)
- SwiftyRSA (1.7.0):
- SwiftyRSA/ObjC (= 1.7.0)
Expand All @@ -1073,7 +1185,6 @@ DEPENDENCIES:
- "callstack-repack (from `../node_modules/@callstack/repack`)"
- DoubleConversion (from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`)
- FBLazyVector (from `../node_modules/react-native/Libraries/FBLazyVector`)
- FBReactNativeSpec (from `../node_modules/react-native/React/FBReactNativeSpec`)
- glog (from `../node_modules/react-native/third-party-podspecs/glog.podspec`)
- hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
- libevent (~> 2.1.12)
Expand All @@ -1098,6 +1209,7 @@ DEPENDENCIES:
- React-jsi (from `../node_modules/react-native/ReactCommon/jsi`)
- React-jsiexecutor (from `../node_modules/react-native/ReactCommon/jsiexecutor`)
- React-jsinspector (from `../node_modules/react-native/ReactCommon/jsinspector-modern`)
- React-jsitracing (from `../node_modules/react-native/ReactCommon/hermes/executor/`)
- React-logger (from `../node_modules/react-native/ReactCommon/logger`)
- React-Mapbuffer (from `../node_modules/react-native/ReactCommon`)
- React-nativeconfig (from `../node_modules/react-native/ReactCommon`)
Expand All @@ -1116,7 +1228,10 @@ DEPENDENCIES:
- React-RCTVibration (from `../node_modules/react-native/Libraries/Vibration`)
- React-rendererdebug (from `../node_modules/react-native/ReactCommon/react/renderer/debug`)
- React-rncore (from `../node_modules/react-native/ReactCommon`)
- React-RuntimeApple (from `../node_modules/react-native/ReactCommon/react/runtime/platform/ios`)
- React-RuntimeCore (from `../node_modules/react-native/ReactCommon/react/runtime`)
- React-runtimeexecutor (from `../node_modules/react-native/ReactCommon/runtimeexecutor`)
- React-RuntimeHermes (from `../node_modules/react-native/ReactCommon/react/runtime`)
- React-runtimescheduler (from `../node_modules/react-native/ReactCommon/react/renderer/runtimescheduler`)
- React-utils (from `../node_modules/react-native/ReactCommon/react/utils`)
- ReactCommon/turbomodule/core (from `../node_modules/react-native/ReactCommon`)
Expand All @@ -1141,8 +1256,6 @@ EXTERNAL SOURCES:
:podspec: "../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec"
FBLazyVector:
:path: "../node_modules/react-native/Libraries/FBLazyVector"
FBReactNativeSpec:
:path: "../node_modules/react-native/React/FBReactNativeSpec"
glog:
:podspec: "../node_modules/react-native/third-party-podspecs/glog.podspec"
hermes-engine:
Expand Down Expand Up @@ -1186,6 +1299,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/jsiexecutor"
React-jsinspector:
:path: "../node_modules/react-native/ReactCommon/jsinspector-modern"
React-jsitracing:
:path: "../node_modules/react-native/ReactCommon/hermes/executor/"
React-logger:
:path: "../node_modules/react-native/ReactCommon/logger"
React-Mapbuffer:
Expand Down Expand Up @@ -1222,8 +1337,14 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/react/renderer/debug"
React-rncore:
:path: "../node_modules/react-native/ReactCommon"
React-RuntimeApple:
:path: "../node_modules/react-native/ReactCommon/react/runtime/platform/ios"
React-RuntimeCore:
:path: "../node_modules/react-native/ReactCommon/react/runtime"
React-runtimeexecutor:
:path: "../node_modules/react-native/ReactCommon/runtimeexecutor"
React-RuntimeHermes:
:path: "../node_modules/react-native/ReactCommon/react/runtime"
React-runtimescheduler:
:path: "../node_modules/react-native/ReactCommon/react/renderer/runtimescheduler"
React-utils:
Expand All @@ -1238,22 +1359,21 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:
boost: 26fad476bfa736552bbfa698a06cc530475c1505
callstack-repack: bbcb691e5e6a19845295770a1178bdf54b1be018
boost: d3f49c53809116a5d38da093a8aa78bf551aed09
callstack-repack: 3aae6e71aaa42062c15b01366dee3dc1b529e5bc
DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
FBLazyVector: fbc4957d9aa695250b55d879c1d86f79d7e69ab4
FBReactNativeSpec: 86de768f89901ef6ed3207cd686362189d64ac88
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2
hermes-engine: 34304f8c6e8fa68f63a5fe29af82f227d817d7a7
hermes-engine: b361c9ef5ef3cda53f66e195599b47e1f84ffa35
JWTDecode: 2eed97c2fa46ccaf3049a787004eedf0be474a87
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
RCT-Folly: 7169b2b1c44399c76a47b5deaaba715eeeb476c0
RCTRequired: 9b1e7e262745fb671e33c51c1078d093bd30e322
RCTTypeSafety: a759e3b086eccf3e2cbf2493d22f28e082f958e6
React: 805f5dd55bbdb92c36b4914c64aaae4c97d358dc
React-callinvoker: 6a697867607c990c2c2c085296ee32cfb5e47c01
React-Codegen: c4447ffa339f4e7a22e0c9c800eec9084f31899c
React-Codegen: f3cb992539e5c21675f087e536d64b1f2a448655
React-Core: 49f66fecc7695464e9b7bc7dc7cd9473d2c60584
React-CoreModules: 710e7c557a1a8180bd1645f5b4bf79f4bd3f5417
React-cxxreact: 345857b5e4be000c0527df78be3b41a0677a20ce
Expand All @@ -1267,14 +1387,15 @@ SPEC CHECKSUMS:
React-jsi: a182068133f80918cd0eec77875abaf943a0b6be
React-jsiexecutor: dacd00ce8a18fc00a0ae6c25e3015a6437e5d2e8
React-jsinspector: 03644c063fc3621c9a4e8bf263a8150909129618
React-jsitracing: 7c77101b38fcc8fa7f198de7e1d834350a85af90
React-logger: 66b168e2b2bee57bd8ce9e69f739d805732a5570
React-Mapbuffer: 9ee041e1d7be96da6d76a251f92e72b711c651d6
React-nativeconfig: d753fbbc8cecc8ae413d615599ac378bbf6999bb
React-NativeModulesApple: 964f4eeab1b4325e8b6a799cf4444c3fd4eb0a9c
React-perflogger: 29efe63b7ef5fbaaa50ef6eaa92482f98a24b97e
React-RCTActionSheet: 69134c62aefd362027b20da01cd5d14ffd39db3f
React-RCTAnimation: 3b5a57087c7a5e727855b803d643ac1d445488f5
React-RCTAppDelegate: a3ce9b69c0620a1717d08e826d4dc7ad8a3a3cae
React-RCTAppDelegate: cb1a9a8447ddad006f934988016390f4df472e74
React-RCTBlob: 26ea660f2be1e6de62f2d2ad9a9c7b9bfabb786f
React-RCTFabric: bb6dbbff2f80b9489f8b2f1d2554aa040aa2e3cd
React-RCTImage: 27b27f4663df9e776d0549ed2f3536213e793f1b
Expand All @@ -1284,13 +1405,16 @@ SPEC CHECKSUMS:
React-RCTText: 73006e95ca359595c2510c1c0114027c85a6ddd3
React-RCTVibration: 599f427f9cbdd9c4bf38959ca020e8fef0717211
React-rendererdebug: f2946e0a1c3b906e71555a7c4a39aa6a6c0e639b
React-rncore: 74030de0ffef7b1a3fb77941168624534cc9ae7f
React-rncore: 6e3139cf51cea08068f008da426821d1deaa24b9
React-RuntimeApple: 08c29690996ed935e35054965bcfb70ebea67318
React-RuntimeCore: 5b73f40b46d78a825cf71714e1e5044d389702d6
React-runtimeexecutor: 2d1f64f58193f00a3ad71d3f89c2bfbfe11cf5a5
React-RuntimeHermes: 01dcb5a4e9073496f6f981a8648843771e3f6516
React-runtimescheduler: df8945a656356ff10f58f65a70820478bfcf33ad
React-utils: f5bc61e7ea3325c0732ae2d755f4441940163b85
ReactCommon: 45b5d4f784e869c44a6f5a8fad5b114ca8f78c53
RNCAsyncStorage: 618d03a5f52fbccb3d7010076bc54712844c18ef
RNSVG: c1e76b81c76cdcd34b4e1188852892dc280eb902
RNCAsyncStorage: 559f22cc4b582414e783fd7255974b29e24b451c
RNSVG: db32cfcad0a221fd175e0882eff7bcba7690380a
SocketRocket: f32cd54efbe0f095c4d7594881e52619cfe80b17
SwiftyRSA: 8c6dd1ea7db1b8dc4fb517a202f88bb1354bc2c6
Yoga: e64aa65de36c0832d04e8c7bd614396c77a80047
Expand Down
12 changes: 10 additions & 2 deletions packages/TesterApp/ios/TesterApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,12 +575,16 @@
);
MTL_ENABLE_DEBUG_INFO = YES;
ONLY_ACTIVE_ARCH = YES;
OTHER_CFLAGS = "$(inherited)";
OTHER_CFLAGS = (
"$(inherited)",
"-DRN_FABRIC_ENABLED",
);
OTHER_CPLUSPLUSFLAGS = (
"$(OTHER_CFLAGS)",
"-DFOLLY_NO_CONFIG",
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
"-DRN_FABRIC_ENABLED",
);
OTHER_LDFLAGS = (
"$(inherited)",
Expand Down Expand Up @@ -650,12 +654,16 @@
"\"$(inherited)\"",
);
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_CFLAGS = "$(inherited)";
OTHER_CFLAGS = (
"$(inherited)",
"-DRN_FABRIC_ENABLED",
);
OTHER_CPLUSPLUSFLAGS = (
"$(OTHER_CFLAGS)",
"-DFOLLY_NO_CONFIG",
"-DFOLLY_MOBILE=1",
"-DFOLLY_USE_LIBCPP=1",
"-DRN_FABRIC_ENABLED",
);
OTHER_LDFLAGS = (
"$(inherited)",
Expand Down
2 changes: 1 addition & 1 deletion packages/TesterApp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"lodash.throttle": "^4.1.1",
"react": "18.2.0",
"react-native": "0.73.2",
"react-native-svg": "^13.7.0"
"react-native-svg": "14.1.0"
},
"devDependencies": {
"@babel/core": "^7.20.0",
Expand Down
Loading
Loading