Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native module typing #641

Merged
merged 14 commits into from
Aug 8, 2024
Merged

fix: native module typing #641

merged 14 commits into from
Aug 8, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Jun 9, 2024

Summary

Closes #494

Test plan

  • - android new arch builds
  • - ios new arch builds

Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:41pm

Copy link

changeset-bot bot commented Jun 9, 2024

🦋 Changeset detected

Latest commit: da3056c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Minor
tester-federation Patch
@callstack/repack-dev-server Minor
@callstack/repack-init Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma
Copy link
Member Author

jbroma commented Jun 12, 2024

It seems that for Android, the generated type stays as ReadableMap, but for iOS the codegen creates a struct for config argument. I'm not sure whether it's worth it to implement that, when we still have to keep compatibility for the old arch - we would have to fork (wrap in ifdefs in this case) a lot of code just to use the typings from codegen.

cc @troZee

Copy link

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 18, 2024
@jbroma jbroma removed the Stale label Jul 18, 2024
@jbroma jbroma merged commit c9eaef8 into main Aug 8, 2024
5 checks passed
@jbroma jbroma deleted the fix/native-module-typing branch August 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve types for prefetchScript and loadScript
2 participants