Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serve source assets #702

Merged
merged 30 commits into from
Sep 30, 2024
Merged

feat: serve source assets #702

merged 30 commits into from
Sep 30, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Aug 21, 2024

Summary

Tooling like Sentry, requests local sources in development - this relies on Metro's ability to fetch local files through fallback handler here

Closes #686

TODO:

  • - add allowed suffixes
  • - add unit tests
  • - verify this doesn't introduce any security vulnerabilities

Test plan

  • - tests pass

Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 11:19am

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 0f842e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Minor
@callstack/repack-dev-server Minor
@callstack/repack-init Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma force-pushed the feat/serve-source-assets branch from 20b97fa to dd20f25 Compare August 22, 2024 08:20
@jbroma
Copy link
Member Author

jbroma commented Aug 22, 2024

@jbroma
Copy link
Member Author

jbroma commented Sep 9, 2024

@jbroma jbroma marked this pull request as ready for review September 30, 2024 10:59
@jbroma jbroma changed the title [WIP] feat: serve source assets feat: serve source assets Sep 30, 2024
@jbroma jbroma merged commit 495203d into main Sep 30, 2024
5 checks passed
@jbroma jbroma deleted the feat/serve-source-assets branch September 30, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File not found in compilation assets causes memory leak
1 participant