Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourceUrl passed to eval for local and remote chunks #711

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Aug 26, 2024

Summary

Closes #665

Test plan

n/a

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 50aae05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 1:31pm

@jbroma
Copy link
Member Author

jbroma commented Aug 26, 2024

needs more changes - mostly default name for output chunks so that everything stays in sync and can be properly parsed, postponed to v5

@jbroma jbroma changed the title fix: source url [WIP] fix: sourceUrl passed to eval for local and remote chunks Aug 26, 2024
Copy link

This pull request has been marked as stale because it has been inactive for 60 days. Please update this pull request or it will be automatically closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 26, 2024
@jbroma jbroma changed the title [WIP] fix: sourceUrl passed to eval for local and remote chunks fix: sourceUrl passed to eval for local and remote chunks Sep 30, 2024
@jbroma jbroma marked this pull request as ready for review September 30, 2024 12:40
@jbroma jbroma removed the Stale label Sep 30, 2024
@jbroma
Copy link
Member Author

jbroma commented Sep 30, 2024

merging as is, will most likely require an alignment in the future

@jbroma jbroma merged commit 7af6d5b into main Sep 30, 2024
5 checks passed
@jbroma jbroma deleted the fix/source-url branch September 30, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sourceURL in raw React Native stack frames is inconsitent
1 participant