Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an error when bundle download was unsuccessful on iOS #745

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

ra1nj
Copy link
Contributor

@ra1nj ra1nj commented Sep 12, 2024

Summary

On iOS ,if download bundle was not successful, throw an error.

Test plan

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 1bf85fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 7:29am

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for another contribution @ra1nj 🎉

@jbroma jbroma changed the title fix: On iOS ,if download bundle was not successful,throw an error. fix: throw an error when bundle download was unsuccessful on iOS Sep 12, 2024
@jbroma jbroma merged commit dbbaf72 into callstack:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants