Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: normalize filepath and ensure path exists for stats writing #750

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Sep 17, 2024

Summary

  • fix TODO in setupStatsWriter
  • moved error handling to bundle command
  • added unit tests for stats writer

Test plan

  • - tests pass

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 10:40am

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 55e793b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Minor
@callstack/repack-dev-server Minor
@callstack/repack-init Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma changed the title fix: normalize filepath for stats writing feat: normalize filepath for stats writing Sep 17, 2024
@jbroma jbroma changed the title feat: normalize filepath for stats writing feat: normalize filepath and ensure path exists for stats writing Sep 17, 2024
@jbroma jbroma merged commit c4a3235 into main Sep 17, 2024
5 checks passed
@jbroma jbroma deleted the fix/stats-writer-todo branch September 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant