Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable package imports by default #755

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Sep 20, 2024

Summary

metro doesn't support import fields at all, aligning for compat.

if a user wants to allow for importsFields, they can do so through resolve.importsFields and restoring the default value of ['imports']

Test plan

n/a

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: a8c93d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 3:28pm

@jbroma jbroma merged commit 90faeeb into main Sep 20, 2024
5 checks passed
@jbroma jbroma deleted the fix/disable-import-fields branch September 20, 2024 15:34
@thymikee
Copy link
Member

Any chance we could have a docs page covering all the custom webpack config we do by default and a reason for doing so (either RN specific thing or Metro quirk)? Sounds like it could be helpful for mobile + web projects reusing as much of their configs as possible

@jbroma
Copy link
Member Author

jbroma commented Sep 20, 2024

Any chance we could have a docs page covering all the custom webpack config we do by default and a reason for doing so (either RN specific thing or Metro quirk)? Sounds like it could be helpful for mobile + web projects reusing as much of their configs as possible

Yeah, should be covered in module resolution docs 👍

artus9033 pushed a commit that referenced this pull request Sep 26, 2024
* fix: disable package imports by default

* chore: add changeset
artus9033 pushed a commit that referenced this pull request Sep 26, 2024
* fix: disable package imports by default

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants