feat: support experimental RN debugger interaction #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interaction is not implemented in the underlying bundler wrapper
🦋 Changeset detectedLatest commit: 0aaed0b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
artus9033
force-pushed
the
feat/support-new-rn-debugger
branch
2 times, most recently
from
ae485b1 to
222629f
Compare
artus9033
force-pushed
the
feat/support-new-rn-debugger
branch
from
222629f to
c6f19f2
Compare
|
demo pls! |
I've just updated the root comment to include a demo GIF. |
|
Do we have a way to display the shortcuts that you can press? |
|
For sure we can, I will have this implemented as well. |
|
Let's make it dead simple, like logging the options once. No need to do anything fancier for now |
|
Done in b93c3f7, also added screenshots ✅ |
jbroma
reviewed
Sep 26, 2024
…etupInteractions test
artus9033
force-pushed
the
feat/support-new-rn-debugger
branch
from
29c1e8a to
ecf383a
Compare
|
this is how final output looks like now: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for the TUI 'j' interaction and implementations of this interaction for Webpack & Rspack.
It also refactors code in
setupInteractions.tsto properly warn about possible (currently none) unsupported interactions in the underlying bundler wrapper implementation, as well as replaces a series ofif-elseexpressions with aswitchand replacing object arrow functions with object literal methods shorthand syntax.Demo
Live interaction:
Initial help message:
Test plan
--experimental-debugger& pressing 'j' should result in warning:DevTools require the '--experimental-debugger' flag to be passed to the bundler process--experimental-debugger& pressing 'j' should result in the DevTools being opened, both for Webpack & Rspack