feat: add util function to generate module paths #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6481f3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jbroma
requested changes
Oct 7, 2024
thiagobrez
commented
Oct 8, 2024
thiagobrez
commented
Oct 8, 2024
|
@jbroma Pushed the requested changes! Let me know what you think about the new test structure. I separated it into logical tests (classic, exotic, backslashes) and think it's much better. Although I had to do some massaging in the regex array returned from the function to be able to have some more scalable tests. |
jbroma
reviewed
Oct 8, 2024
|
Thank you for working on this @thiagobrez, very useful stuff 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
getModulePathsutil function, to generate module path regexes for both classic (npm, yarn) and exotic (pnpm) paths, to be used in the bundler config fileincluderules.This function will be available for both internal and public use.
Test plan
Tests to classic and exotic module paths are included, also taking in consideration nested packages and backslashes from Windows systems.