Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source-map matching in React Native DevTools #787

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Nov 8, 2024

Summary

Fix bad source-map matching in DevTools by aligning the following:

  • - add namespace to SourceMapDevToolPlugin
  • - align sourceURL that gets passed to JSI evaluateJavascript

Before:
image

After:
image

Test plan

  • - proper mapping in DevTools in testers on iOS
  • - proper mapping in DevTools in testers on Android

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 28b663e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 4:55pm

@jbroma jbroma changed the title fix: proper fix: source-map matching in React Native DevTools Nov 8, 2024
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document the addition of sourceUrl somewhere?

@jbroma
Copy link
Member Author

jbroma commented Nov 8, 2024

Could you document the addition of sourceUrl somewhere?

It's not an addition per se but a fix, previously we were using the wrong value for that.

We should do a whole doc page on using DevTools and dealing with issues, I'll create a separate issue for that 👍

The only thing that user needs to do here is to remember to set output.uniqueName

@jbroma jbroma merged commit acdd0c8 into main Nov 8, 2024
5 checks passed
@jbroma jbroma deleted the fix/source-maps-in-debugger branch November 8, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants