-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: source-map matching in React Native DevTools #787
Conversation
🦋 Changeset detectedLatest commit: 28b663e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you document the addition of sourceUrl somewhere?
packages/repack/android/src/main/java/com/callstack/repack/ScriptConfig.kt
Outdated
Show resolved
Hide resolved
It's not an addition per se but a fix, previously we were using the wrong value for that. We should do a whole doc page on using DevTools and dealing with issues, I'll create a separate issue for that 👍 The only thing that user needs to do here is to remember to set |
Summary
Fix bad source-map matching in DevTools by aligning the following:
SourceMapDevToolPlugin
sourceURL
that gets passed to JSIevaluateJavascript
Before:
After:
Test plan