Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obtain asset size from first asset in group #814

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 6, 2024

Summary

Align how size of an asset is obtained with the behaviour in metro. This also prevents erroring out if the default asset in group can't be established.

Test plan

  • - testers work

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: ccdfd0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Dec 6, 2024 4:27pm

@jbroma jbroma merged commit 592fbe3 into main Dec 8, 2024
5 checks passed
@jbroma jbroma deleted the fix/default-asset-scale branch December 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant