Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore the MF2 runtime warning #821

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 10, 2024

Summary

This PR addresses the warnings produced by Module Federation v2 (MF2) regarding dynamic imports in the loadEsmEntry function. These warnings are not relevant in the React Native environment since the loadEntry logic is overridden through a hook.

image

Test plan

n/a

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: e958c8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch
@callstack/repack-plugin-reanimated Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 9:28pm

@jbroma jbroma merged commit 287991e into main Dec 10, 2024
5 checks passed
@jbroma jbroma deleted the fix/ignore-federation-warnings branch December 10, 2024 21:31
@thymikee
Copy link
Member

Yes please! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants