Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adb reverse interaction & run adb reverse by default #824

Merged
merged 10 commits into from
Dec 16, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Dec 12, 2024

Summary

  • - add adb reverse interaction under a
  • - run adb reverse by default
  • - automatic adb reverse logs are now debug only
  • - manual trigger of adb reverse through interaction shows up in logs normally

I didn't want to introduce a breaking change in CLI options in this PR so for now we check if the platform is not ios. Separate PR will change the --reverse-port flag into --no-reverse-port

Test plan

  • - unit tessts pass
  • - adb interaction works in testers

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Dec 12, 2024 6:46pm

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 6311eec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma requested a review from thymikee December 12, 2024 18:49
@jbroma jbroma merged commit 8cf7cc3 into main Dec 16, 2024
5 checks passed
@jbroma jbroma deleted the feat/adb-reverse-auto branch December 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants