fix: handle early JS errors like in Metro #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 93a4668 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thymikee
reviewed
Dec 18, 2024
packages/repack/src/plugins/RepackTargetPlugin/implementation/init.ts
Outdated
Show resolved
Hide resolved
thymikee
approved these changes
Dec 18, 2024
|
added some extra error handling for a rare scenario where there might be no |
|
thank you for the review @thymikee 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #621
Closes #794
This PR fixes the problem where early JS errors on iOS would result in a white screen without any meaningful information. Early JS errors are now visible on both platforms inside a LogBox window (parity with Metro).
For now caching of module errors is disabled (as we disable
strictErrorModuleHandlingin the Target Plugin) and we should handle this in the interceptor as well in the future.Separate PR should address formatting of the errors to match the presets here (or we could override the whole module and parse LogBoxLog ourselves)
Screenshots
Syntax error showing up in LogBox (although not being parsed correctly, see reason above):
Early JS errors visible on iOS
Test plan