Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Module Resolution Errors for ScriptManager Imports #833

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

mrsasuu
Copy link
Contributor

@mrsasuu mrsasuu commented Dec 20, 2024

This PR resolves the module resolution errors that caused the server to fail during startup. The issues stemmed from incorrect import paths for CorePlugin and ResolverPlugin, as well as the ScriptManager module.

Screenshot 2024-12-20 at 10 41 07

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 67a8ed5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 11:36am

@mrsasuu mrsasuu requested a review from jbroma December 20, 2024 09:36
@mrsasuu mrsasuu self-assigned this Dec 20, 2024
@mrsasuu mrsasuu added the type:bug A bug report. label Dec 20, 2024
@jbroma
Copy link
Member

jbroma commented Dec 20, 2024

@mrsasuu thanks for the PR, can you please add a changeset to this PR describing the change in once sentence? You can add it via pnpm changeset add in the root of the repo

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nits

@@ -0,0 +1,5 @@
---
"@callstack/repack": major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a major change - this is patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@callstack/repack": major
---

Module Resolution Errors for ScriptManager Imports in FederationRuntimePlugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit too vague - I think something like "Fix bad import in MF runtime plugins" would be more descriptive, WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrsasuu mrsasuu requested a review from jbroma December 20, 2024 11:37
@jbroma
Copy link
Member

jbroma commented Dec 20, 2024

LGMT 🎉 Thanks for spotting and fixing this @mrsasuu !

@jbroma jbroma merged commit 860553b into callstack:main Dec 20, 2024
5 checks passed
@mrsasuu mrsasuu deleted the fix/missing-module-resolution branch December 20, 2024 11:41
jbroma added a commit that referenced this pull request Dec 20, 2024
jbroma added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A bug report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants