-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Module Resolution Errors for ScriptManager Imports #833
Conversation
🦋 Changeset detectedLatest commit: 67a8ed5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@mrsasuu thanks for the PR, can you please add a changeset to this PR describing the change in once sentence? You can add it via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nits
.changeset/quiet-camels-design.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"@callstack/repack": major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a major change - this is patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.changeset/quiet-camels-design.md
Outdated
"@callstack/repack": major | ||
--- | ||
|
||
Module Resolution Errors for ScriptManager Imports in FederationRuntimePlugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels a bit too vague - I think something like "Fix bad import in MF runtime plugins" would be more descriptive, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 🎉 Thanks for spotting and fixing this @mrsasuu ! |
This PR resolves the module resolution errors that caused the server to fail during startup. The issues stemmed from incorrect import paths for CorePlugin and ResolverPlugin, as well as the ScriptManager module.