test: Fix flaky tests after yarnpkg#4811 due to bad assumptions (yarn…

…pkg#4852)

**Summary**

Tests started failing on Travis after yarnpkg#4811, somewhat randomly, due to them expecting the unwrapped
output. This PR fixes those expectations and moves normalize-manifest tests to snapshots since
that's easier than updating 40+ JSON files by hand.

**Test plan**

Tests should pass on all platforms and CI and locally.

__tests__/__snapshots__/normalize-manifest.js.snap

@@ -0,0 +1,211 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`author object normalize 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`author string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`authors file to contributors 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`bin string 1`] = `
+Array [
+  "foo: No license field",
+]
+`;
+
+exports[`binding.gyp scripts.install 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`bugs string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`bundledDependencies alias 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`clean version 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`clean version with v 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`contributors array expand 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`dedupe all trivial dependencies 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`dedupe dependencies 1`] = `Array []`;
+
+exports[`dedupe dependencies root 1`] = `
+Array [
+  "No license field",
+  "\\"dependencies\\" has dependency \\"foobar\\" with range \\"2.0.0\\" that collides with a dependency in \\"devDependencies\\" of the same name with version \\"1.0.0\\"",
+]
+`;
+
+exports[`dedupe optionalDependencies 1`] = `Array []`;
+
+exports[`dedupe optionalDependencies root 1`] = `
+Array [
+  "No license field",
+  "\\"optionalDependencies\\" has dependency \\"foobar\\" with range \\"1.0.0\\" that collides with a dependency in \\"dependencies\\" of the same name with version \\"2.0.0\\"",
+]
+`;
+
+exports[`dedupe single trivial dependency 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`engines array 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`explode directories.bin 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`explode directories.man 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`extract description 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`homepage string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`hosted git repository url 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`keywords string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`license warnings should not be thrown with global commands 1`] = `Array []`;
+
+exports[`maintainers array expand 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`man string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`name 1`] = `
+Array [
+  "foobar: No license field",
+]
+`;
+
+exports[`readme 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`repository string 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`scoped bin string 1`] = `
+Array [
+  "@scope/foo: No license field",
+]
+`;
+
+exports[`server scripts.start 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`valid license 1`] = `Array []`;
+
+exports[`version 1`] = `
+Array [
+  "No license field",
+]
+`;
+
+exports[`warn builtin module collision 1`] = `
+Array [
+  "fs: \\"fs\\" is also the name of a node core module",
+  "fs: No license field",
+]
+`;
+
+exports[`warn empty string invalid license 1`] = `
+Array [
+  "License should be a valid SPDX license expression",
+]
+`;
+
+exports[`warn invalid license 1`] = `
+Array [
+  "License should be a valid SPDX license expression",
+]
+`;
+
+exports[`warn typo 1`] = `
+Array [
+  "Potential typo \\"dependancies\\", did you mean \\"dependencies\\"?",
+  "No license field",
+]
+`;

__tests__/commands/install/bin-links.js

@@ -31,7 +31,7 @@ function execCommand(cwd: string, binPath: Array<string>, args: Array<string>):
         cwd,
         env: {
           ...process.env,
-          YARN_SILENT: 0,
+          YARN_WRAP_OUTPUT: 1,
         },
       },
       (error, stdout) => {

__tests__/index.js

@@ -34,6 +34,7 @@ async function execCommand(
   return new Promise((resolve, reject) => {
     const cleanedEnv = {...process.env};
     cleanedEnv['YARN_SILENT'] = 0;
+    cleanedEnv['YARN_WRAP_OUTPUT'] = 1;
     delete cleanedEnv['FORCE_COLOR'];
 
     exec(
@@ -121,7 +122,7 @@ test.concurrent('should add package with no-lockfile option', async () => {
   expectAddSuccessfullOutputWithNoLockFile(stdout, 'repeating');
 });
 
-test.concurrent('should add package with frozzen-lockfile option', async () => {
+test.concurrent('should add package with frozen-lockfile option', async () => {
   const stdout = await execCommand('add', ['repeating', '--frozen-lockfile'], 'run-add-option', true);
   expectAddSuccessfullOutputWithNoLockFile(stdout, 'repeating');
 });

__tests__/lifecycle-scripts.js

@@ -20,7 +20,7 @@ async function execCommand(cmd: string, packageName: string, env = process.env):
 
   return new Promise((resolve, reject) => {
     const cleanedEnv = {...env};
-    cleanedEnv['YARN_SILENT'] = 0;
+    cleanedEnv['YARN_WRAP_OUTPUT'] = 1;
     delete cleanedEnv['FORCE_COLOR'];
 
     exec(