Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for SubscribeMessageHandler #17

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Conversation

cameri
Copy link
Owner

@cameri cameri commented Oct 23, 2022

Description

  1. Add unit tests to SubscribeMessageHandler

Related Issue

Part of #3

Motivation and Context

  • Increase unit test coverage to above 80%

How Has This Been Tested?

  1. Unit tests

Screenshots (if appropriate):

image

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri self-assigned this Oct 23, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3309002478

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.9%) to 70.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adapters/web-socket-adapter.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 3301265399: 5.9%
Covered Lines: 466
Relevant Lines: 685

💛 - Coveralls

@cameri cameri merged commit 20cc671 into main Oct 23, 2022
@cameri cameri deleted the test/subscriptions branch October 23, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants