Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for NIP-1 #18

Merged
merged 13 commits into from
Oct 28, 2022
Merged

Conversation

cameri
Copy link
Owner

@cameri cameri commented Oct 25, 2022

Description

  1. Refactor application entry point to make it easier to test
  2. Add cucumber library
  3. Rename test & test:watch script to test:unit and test:unit:watch respectively

Related Issue

#5

Motivation and Context

Needed to refactor the application entry-point so that it can easily be tested with integration tests.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue Oct 25, 2022 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Oct 25, 2022

Pull Request Test Coverage Report for Build 3342916036

  • 10 of 84 (11.9%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.3%) to 69.318%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/adapters/web-server-adapter.ts 0 1 0.0%
src/adapters/web-socket-adapter.ts 0 3 0.0%
src/adapters/web-socket-server-adapter.ts 0 3 0.0%
src/factories/app-factory.ts 0 6 0.0%
src/index.ts 0 7 0.0%
src/app/worker.ts 0 14 0.0%
src/factories/worker-factory.ts 0 16 0.0%
src/app/app.ts 0 24 0.0%
Files with Coverage Reduction New Missed Lines %
src/adapters/web-socket-adapter.ts 2 0%
Totals Coverage Status
Change from base Build 3333350338: -1.3%
Covered Lines: 465
Relevant Lines: 693

💛 - Coveralls

@cameri cameri force-pushed the 5-add-integration-tests-for-nip-1 branch from 9030bbb to a9eaddf Compare October 26, 2022 22:56
@cameri cameri force-pushed the 5-add-integration-tests-for-nip-1 branch from 259e3f6 to bdece62 Compare October 28, 2022 04:58
@cameri cameri enabled auto-merge (rebase) October 28, 2022 04:59
@cameri cameri disabled auto-merge October 28, 2022 05:08
@cameri cameri merged commit 6e68c33 into main Oct 28, 2022
@cameri cameri deleted the 5-add-integration-tests-for-nip-1 branch October 28, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests for NIP-1
2 participants