Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to KDL 2.0 #190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danini-the-panini
Copy link

@danini-the-panini danini-the-panini commented Dec 24, 2024

Pretty much what it says on the box. Since kdl-rb 2.x is fully backwards compatible with v1 (in both syntax and public interface) this should not cause any breaking changes, and can safely be included in a minor version bump.

  • Upgrade kdl gem to 2.0.0
  • Update config.yml to use new 2.0.0 syntax
  • Add warning if config uses v1 syntax

@danini-the-panini
Copy link
Author

@karloscarweber This is a trivial update to kdl 2.0

I've noticed now that the Kuddly module uses regexp to parse the line and column from the error message, which got me thinking that it would be beneficial to expose those values directly, which I have done here: danini-the-panini/kdl-rb#20

However that would probably constitute a minor version bump according to semver, so I think I'd like to hold off on pushing that up until we've added some more useful features and interface improvements. If you have any ideas I'd love to hear them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant