fix: fix cargo bolero list when some tests are failing
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, `cargo bolero list` would ignore any fuzzers defined after a binary with one failing test. With this change, it properly lists all fuzzers. This was prompted by my discovering our fuzzing infra’s builds with `cargo bolero build-clusterfuzz` had empty fuzzer tarballs, because one test was failing before the fuzzers were discovered.
camshaft
approved these changes
Nov 8, 2023
|
Thanks! |
|
Thank you for the quick merge! :) A proper fix would be #196 (I couldn’t find the place where we had already discussed this), but hopefully this’ll make do in the meantime :) |
github-merge-queue bot
pushed a commit
to near/nearcore
that referenced
this pull request
Nov 9, 2023
… tests (#10131) We have tests that fail with `cargo test`, and this throws off `cargo bolero list`, that runs `cargo test` to list the fuzzers. With this change, we add camshaft/bolero#195, that ignores such failures and actually lists all fuzzers. This should fix the issue, that all the latest uploads to the fuzzers bucket actually were empty tarballs. --------- Co-authored-by: Simonas Kazlauskas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
cargo bolero listwould ignore any fuzzers defined after a binary with one failing test. With this change, it properly lists all fuzzers.This was prompted by my discovering our fuzzing infra’s builds with
cargo bolero build-clusterfuzzhad empty fuzzer tarballs, because one test was failing before the fuzzers were discovered.I also added a regression test.