-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make source variables filtering more powerful #80
Comments
Ok - thx for reporting. I will update the docs. |
It would be better if this worked like it was initially planned, so that we can define the list of variables to send inside each workflow, not as part of the source connector configuration. This would give us more flexibility. |
In the readme (https://github.com/camunda-community-hub/kafka-connect-zeebe) it says:
This might be a bit misleading - so we should be clear that this is defined by the This property is used to limit querying the variables for every job. If we would want to filter based on a task header, this would be a feature request that requires a bit of effort to make happen. And I guess we would need to query all variables - and then "just" limit what is sent to Kafka, as everything else would mean we somehow need to parse the BPMN model to read task header configuration statically (we might want to make that easy with the upcoming connector framework - but not yet there). Could you imagine providing a PR for the "fetch all variables but limit what we send out by task header config" feature @aragornfbm? |
Let me see what I can do @berndruecker |
@berndruecker I created the pull request #99 to implement this feature. |
According to the documentation, the "job.variables" property should contain the name of a custom header that is defined in the source task and that contains a comma-separated list of variables that should be included in the produced Kafka message.
In the current implementation (0.32.0), the value put in "job.variables" is used as the actual list of variable names, not as a reference to the header containing the list of variables.
The text was updated successfully, but these errors were encountered: