Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make source variables filtering more powerful #80

Open
aragornfbm opened this issue May 20, 2022 · 5 comments
Open

Make source variables filtering more powerful #80

aragornfbm opened this issue May 20, 2022 · 5 comments

Comments

@aragornfbm
Copy link

According to the documentation, the "job.variables" property should contain the name of a custom header that is defined in the source task and that contains a comma-separated list of variables that should be included in the produced Kafka message.

In the current implementation (0.32.0), the value put in "job.variables" is used as the actual list of variable names, not as a reference to the header containing the list of variables.

@berndruecker berndruecker self-assigned this Jul 15, 2022
@berndruecker
Copy link
Collaborator

Ok - thx for reporting. I will update the docs.

@aragornfbm
Copy link
Author

It would be better if this worked like it was initially planned, so that we can define the list of variables to send inside each workflow, not as part of the source connector configuration. This would give us more flexibility.

@berndruecker
Copy link
Collaborator

In the readme (https://github.com/camunda-community-hub/kafka-connect-zeebe) it says:

You can filter the variables being sent to Kafka by adding a custom header to the "sendMessage" task with the configuration option "job.variables". Set the value of this key to a comma-separated list of variables to pass to Kafka.

This might be a bit misleading - so we should be clear that this is defined by the source.json instead. I will fix this right away.

This property is used to limit querying the variables for every job.

If we would want to filter based on a task header, this would be a feature request that requires a bit of effort to make happen. And I guess we would need to query all variables - and then "just" limit what is sent to Kafka, as everything else would mean we somehow need to parse the BPMN model to read task header configuration statically (we might want to make that easy with the upcoming connector framework - but not yet there).

Could you imagine providing a PR for the "fetch all variables but limit what we send out by task header config" feature @aragornfbm?

berndruecker added a commit that referenced this issue Jul 25, 2022
@berndruecker berndruecker changed the title Source variables filtering is not working Make source variables filtering more powerful Jul 27, 2022
@berndruecker berndruecker removed their assignment Jul 27, 2022
@aragornfbm
Copy link
Author

Let me see what I can do @berndruecker

aragornfbm pushed a commit to aragornfbm/kafka-connect-zeebe that referenced this issue Jul 30, 2022
aragornfbm added a commit to aragornfbm/kafka-connect-zeebe that referenced this issue Jul 30, 2022
@aragornfbm
Copy link
Author

@berndruecker I created the pull request #99 to implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants