Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Catch cancelled error status from gateway #215

Merged

Conversation

JonatanMartens
Copy link
Collaborator

@JonatanMartens JonatanMartens commented Sep 10, 2021

When a zeebe gateway is restarted, the worker/client will receive a status of CANCELLED. This is currently not caught in pyzeebe. See #213

Changes

  • Catch cancelled status and add to retry count

API Updates

New Features

none

Deprecations

none

Enhancements

  • Make ZeebeAdapterBase.is_error_status accept a list of error statuses. Does not break current usages

Checklist

  • Unit tests
  • Documentation

References

Fixes #213

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2021

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Sep 10, 2021

Pull Request Test Coverage Report for Build 1222157217

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.32%

Totals Coverage Status
Change from base Build 1222065375: 0.0%
Covered Lines: 714
Relevant Lines: 757

💛 - Coveralls

@JonatanMartens JonatanMartens merged commit 3e4fce4 into pre-release/3.0.0 Sep 27, 2021
@JonatanMartens JonatanMartens deleted the bugfix/213-worker-stops-after-zeebe-restart branch September 27, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants