feature: use the client to send SetVariablesCommand with retries #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisKujawa
reviewed
Oct 6, 2021
There was a problem hiding this comment.
Thanks @askalik 👍
please add a test case as described here #329 (comment)
resolving merge conflicts added test provider data for set variables update feature: use the client to send SetVariablesCommand with retries
…thub.com/askalik/zeebe-client-csharp into feature_SetVariablesCommand_with_retries
|
@Zelldon I took TestDataProvider from the main branch and added the new TestData in it is saying there are still conflicts. Not sure how else to resolve? |
|
Hey @askalik thanks for your contribution I resolved the merge conflict, but please take a look at the failing build https://github.com/camunda-community-hub/zeebe-client-csharp/pull/332/checks?check_run_id=3820082070 after you fixed it we can merge the PR |
|
@Zelldon I believe I have the tests updated and passing all checks now. |
|
Thanks @askalik 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #181
Believe this should resolve issue #181