Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivateJobsCommand updated to set tenantIds. #594

Conversation

ShawnAbshire
Copy link
Contributor

Updates ActivateJobsCommand to support TenantIds.

This is the second interface I would like to introduce for TenantIds.

This continues the work to update the various builders to support multi-tenancy in 591

@ChrisKujawa
Copy link
Collaborator

@ShawnAbshire lets do the same as we did here #593

  • commit message adjustment
  • tenant interface to the last step

@ShawnAbshire ShawnAbshire force-pushed the sabshire-multi-tenancy-activatejobs branch from b4d1825 to 4eafab4 Compare November 18, 2023 00:50
@ShawnAbshire
Copy link
Contributor Author

Updated.

Copy link
Collaborator

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼 Lets improve the comments than I guess we are good to go

Client/Api/Commands/ITenantIdsCommandStep.cs Show resolved Hide resolved
Client/Api/Commands/ITenantIdsCommandStep.cs Outdated Show resolved Hide resolved
Client/Api/Commands/ITenantIdsCommandStep.cs Outdated Show resolved Hide resolved
Client/Api/Commands/ITenantIdsCommandStep.cs Outdated Show resolved Hide resolved
Client/Api/Commands/ITenantIdsCommandStep.cs Show resolved Hide resolved
Client/Api/Commands/ITenantIdsCommandStep.cs Outdated Show resolved Hide resolved

namespace Zeebe.Client.Api.Commands
{
public interface ITenantIdsCommandStep<out T>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 We could either add here a single AddTenant or extend the previous introduced interface

@ChrisKujawa
Copy link
Collaborator

Thanks for the contribution @ShawnAbshire 🚀

@ChrisKujawa ChrisKujawa merged commit fd27f56 into camunda-community-hub:main Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants