-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: OAuth2TokenProvider for Authentication Against Self-Hosted Camunda Stack (503) #607
Conversation
Hey @LennartKleymann first of all thank you very much for your time and effort and creating this contribution. I really appreciate that! Unfortunately, I have limited time to maintain this project, so please bear with me. One thing I already saw that might be great to do from your side:
I try my best to review it soon. |
b5679d3
to
a8843db
Compare
…espace and folder
…uth2TokenProvider
…ion tests with camunda identity stack
a8843db
to
346cde3
Compare
Hi @Zelldon, I've completed the signing of the CLA and have divided my extensive commit into smaller ones, adhering to the commit guidelines. While I understand the practice of splitting pull requests (PRs), I believe consolidating them into a single PR is more suitable in this case, as it encompasses a cohesive feature. |
Would love to see this PR being merged, i'm missing this feature and need it in order to remove a dirty workaround. |
I try to review asap but zeebe project and other thing keep me busy :) @fabianschurz maybe you want to give feedback from the user perspective if this would be something you would like to see and use like it is rjght now already. |
@Zelldon |
I would love to see this PR accepted. After upgrading my local camunda-stack it was a nightmare to get authentication done right (before I made unauthorized requests). Thanks to this PR I have a workaround for token retrieval. |
Hey, thanks all for your interest in this PR and especially to @LennartKleymann for contributing. I reiterated over it and created #625 (which is merged now). I will release a new version soon. |
Hey! 👋 I've just introduced an OAuth2TokenProvider to facilitate authentication against a self-hosted zeebe stack. I'd love to hear your thoughts and feedback on this addition.
Changelog:
OAuth2TokenProvider:
Integration Tests:
Unit Tests:
Looking forward to your valuable feedback!