-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deployment): Added support for form deployment response #649
fix(deployment): Added support for form deployment response #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution!
It would be great if we could also extend the test cases we have related to deployments. As example see this https://github.com/camunda-community-hub/zeebe-client-csharp/blob/main/Client.UnitTests/DeploymentTest.cs#L262
Maybe you can add one with forms as well, so we validate everything is set correctly.
Sure thing! I'll try to get it done soon. |
@Zelldon I've extended the tests for multiple deploy resources to also cover form deployments. Let me know if that is sufficient or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so sorry for the delay! I was quite busy with other projects. Thank you again for your contribution! Looks great.
I guess would be great to have an IT test for this as well (can be easily done in our IT subproject). But I can do this myself, later :)
Looks like CI is not running. I will check this first. |
This PR adds support for form deployment response and closes #648
I've tried to keep the implementation as similar as possible to the existing deployment response types. Let me know if there is anything else I should include in this PR.