add white-label options for title, custom logo, code and styles #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vascript incl. some test to show custom files loaded incl. readme and documentation
|
|
|
@nitram509 thank you for your contribution 🎉 I'll look into your PR when I'm back from vacation 🌴 |
saig0
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
@nitram509 nice 👍
I don't know how this is implemented usually. As far as I can tell, it looks good 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we're using Zeebe Simple Monitor in multiple environments like DEV, STAGE, and PROD.
I would like to highlight what environment I'm in by changing colors and logos on the page.
E.g. green for test and red for PROD.
That basic wish led me to the idea, to enable basic white-label features for CSS, JS, the logo, and the title.
This PR adds some new options in the application yaml, extends the ViewController
and obviously adds some tests to be safe in the future.
I took the freedom to drop the empty test class in favor of some real one.
Any feedback is welcome.