Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error page if context path is configured #286

Merged
merged 8 commits into from
Aug 16, 2021

Conversation

jbiblio
Copy link
Contributor

@jbiblio jbiblio commented Aug 10, 2021

Please refer to #279 and #282. I'm creating a new PR, to circumvent an issue with cla-assistant. See comments over there.

In short, I'd like to improve the error handling by establishing a dedicated ExceptionHandler.

@jbiblio jbiblio marked this pull request as ready for review August 10, 2021 06:26
nitram509 added a commit to nitram509/zeebe-simple-monitor that referenced this pull request Aug 10, 2021
Replace Runtime Exception with proper ResponseStatusException.
Hint: the later will also improve/relate to PR camunda-community-hub#286 "Feature/error handler2"
@celanthe celanthe requested a review from saig0 August 10, 2021 13:33
Copy link
Contributor

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbiblio thanks 🍰 It looks good 👍

@saig0 saig0 changed the title Feature/error handler2 Show error page if context path is configured Aug 16, 2021
@saig0 saig0 changed the title Show error page if context path is configured Fix error page if context path is configured Aug 16, 2021
@saig0 saig0 merged commit 4bd4fb6 into camunda-community-hub:master Aug 16, 2021
nitram509 pushed a commit to nitram509/zeebe-simple-monitor that referenced this pull request Aug 27, 2021
…y-hub#286)

* fixing the error page by providing the required model data
@jbiblio jbiblio deleted the feature/error_handler2 branch October 6, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants