-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bundle a MySQL driver #451
Conversation
@ian4h thank you for your contribution. 🎉 I'll have a look at your PR in the next few days. 👀 |
Hi @saig0 ok thanks no rush. |
Sounds fine to me. 👍 Thank you for coming up with the solution immediately. |
@ian4h it would be nice to add a new profile for MySQL to the docker-compose file. It would make the testing a lot easier. |
HI @saig0 ok that makes sense. I've added a new profile to the docker compose file. In order to test the docker-compose was working I built the docker image locally and changed the image for the simple-monitor-mysql container to point at my local version instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ian4h looks all good. Your PR is ready to merge. 🎉
Add the mysql driver as a dependency.
As discusse in issue: #337
Based on previouse work to add the Postgres driver: #307