Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: param name for Spring not specified, raised an IllegalArgumentException in Spring 3.2 #631

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
import io.zeebe.monitor.entity.ProcessInstanceEntity;
import io.zeebe.monitor.rest.dto.AuditLogEntry;
import io.zeebe.monitor.rest.dto.ProcessInstanceDto;
import jakarta.transaction.Transactional;
import java.io.ByteArrayInputStream;
import java.time.Instant;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.stream.Collectors;
import jakarta.transaction.Transactional;
import org.springframework.data.domain.Pageable;
import org.springframework.data.web.PageableDefault;
import org.springframework.stereotype.Controller;
Expand All @@ -29,7 +29,7 @@ public class InstancesAuditLogViewController extends AbstractInstanceViewControl
@GetMapping("/views/instances/{key}/audit-log")
@Transactional
public String instanceDetailAuditLog(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {
initializeProcessInstanceDto(key, model, pageable);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class InstancesCalledProcessesListViewController extends AbstractInstance
@GetMapping("/views/instances/{key}/called-processes-list")
@Transactional
public String instanceDetailCalledProcessesList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public class InstancesErrorListViewController extends AbstractInstanceViewContro
@GetMapping("/views/instances/{key}/error-list")
@Transactional
public String instanceDetailErrorList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public class InstancesIncidentListViewController extends AbstractInstanceViewCon
@GetMapping("/views/instances/{key}/incident-list")
@Transactional
public String instanceDetailIncidentList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class InstancesJobListViewController extends AbstractInstanceViewControll
@GetMapping("/views/instances/{key}/job-list")
@Transactional
public String instanceDetailJobList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class InstancesMessageSubscriptionListViewController extends AbstractInst
@GetMapping("/views/instances/{key}/message-subscription-list")
@Transactional
public String instanceDetailMessageSubscriptionList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {
initializeProcessInstanceDto(key, model, pageable);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class InstancesTimerListViewController extends AbstractInstanceViewContro
@GetMapping("/views/instances/{key}/timer-list")
@Transactional
public String instanceDetailTimerList(
@PathVariable(name = "key") final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class InstancesVariableListController extends AbstractInstanceViewControl
@GetMapping("/views/instances/{key}")
@Transactional
public String instanceVariableList(
@PathVariable final long key,
@PathVariable("key") final long key,
final Map<String, Object> model,
@PageableDefault(size = DETAIL_LIST_SIZE) final Pageable pageable) {
return instanceDetailVariableList(key, model, pageable);
Expand All @@ -38,7 +38,7 @@ public String instanceVariableList(
@GetMapping("/views/instances/{key}/variable-list")
@Transactional
public String instanceDetailVariableList(
@PathVariable final long key, final Map<String, Object> model, final Pageable pageable) {
@PathVariable("key") final long key, final Map<String, Object> model, final Pageable pageable) {

initializeProcessInstanceDto(key, model, pageable);
model.put("content-variable-list-view", new EnableConditionalViewRenderer());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public String processList(final Map<String, Object> model, final Pageable pageab
@GetMapping("/views/processes/{key}")
@Transactional
public String processDetail(
@PathVariable final long key, final Map<String, Object> model, final Pageable pageable) {
@PathVariable("key") final long key, final Map<String, Object> model, final Pageable pageable) {

final ProcessEntity process =
processRepository
Expand Down