feat: fix the ZeebeClusterBuilderTest

Expand assertions to the `singleElement` and `satisfies`
camunda-community-hub · Jun 1, 2021 · 8e47c3e · 8e47c3e
1 parent d55f7b7
commit 8e47c3e
Showing 1 changed file with 26 additions and 12 deletions.
diff --git a/src/test/java/io/zeebe/containers/cluster/ZeebeClusterBuilderTest.java b/src/test/java/io/zeebe/containers/cluster/ZeebeClusterBuilderTest.java
@@ -24,6 +24,7 @@
 import io.zeebe.containers.ZeebeNode;
 import java.util.HashSet;
 import java.util.Map;
+import java.util.Map.Entry;
 import java.util.Set;
 import org.assertj.core.api.Condition;
 import org.junit.jupiter.api.Test;
@@ -521,9 +522,12 @@ void shouldSetImageNameForGateways() {
     final ZeebeCluster cluster = builder.build();
 
     // then
-    final Map<String, ZeebeGatewayNode<? extends GenericContainer<?>>> gateways =
-        cluster.getGateways();
-    assertThat(gateways).hasSize(1).hasValueSatisfying(zeebeImageHasImageName(zeebeDockerImage));
+    assertThat(cluster
+      .getGateways()
+      .entrySet())
+      .as("the only gateway created has the right docker image")
+      .singleElement()
+      .satisfies(gatewayEntry -> verifyZeebeHasImageName(gatewayEntry.getValue(), zeebeDockerImage));
   }
 
   @Test
@@ -538,9 +542,12 @@ void shouldSetImageNameForBrokers() {
     final ZeebeCluster cluster = builder.build();
 
     // then
-    final Map<Integer, ZeebeBrokerNode<? extends GenericContainer<?>>> brokers =
-        cluster.getBrokers();
-    assertThat(brokers).hasSize(1).hasValueSatisfying(zeebeImageHasImageName(zeebeDockerImage));
+    assertThat(cluster
+      .getBrokers()
+      .entrySet())
+      .as("the only broker created has the right docker image")
+      .singleElement()
+      .satisfies(brokerEntry -> verifyZeebeHasImageName(brokerEntry.getValue(), zeebeDockerImage));
   }
 
   @Test
@@ -559,17 +566,24 @@ void shouldSetImageNameForGatewaysAndBrokers() {
     final ZeebeCluster cluster = builder.build();
 
     // then
-    final Map<Integer, ZeebeBrokerNode<? extends GenericContainer<?>>> brokers =
-        cluster.getBrokers();
-    assertThat(brokers).hasSize(1).hasValueSatisfying(zeebeImageHasImageName(zeebeDockerImage));
-    final Map<String, ZeebeGatewayNode<? extends GenericContainer<?>>> gateways =
-        cluster.getGateways();
-    assertThat(gateways).hasSize(1).hasValueSatisfying(zeebeImageHasImageName(zeebeDockerImage));
+    assertThat(cluster.getBrokers().entrySet())
+      .as("the only broker created has the right docker image")
+      .singleElement()
+      .satisfies(brokerEntry -> verifyZeebeHasImageName(brokerEntry.getValue(), zeebeDockerImage));
+    assertThat(cluster.getGateways().entrySet())
+      .as("the only standalone gateway created has the right docker image")
+      .singleElement()
+      .satisfies(gatewayEntry -> verifyZeebeHasImageName(gatewayEntry.getValue(), zeebeDockerImage));
   }
 
   private Condition<ZeebeNode<? extends GenericContainer<?>>> zeebeImageHasImageName(
       final String imageName) {
     return new Condition<>(
         node -> node.getDockerImageName().equals(imageName), "Image Name Condition");
   }
+
+  private void verifyZeebeHasImageName(final ZeebeNode<? extends GenericContainer<?>> zeebe,
+    final String imageName) {
+    assertThat(zeebe.getDockerImageName()).isEqualTo(imageName);
+  }
 }