fix(asyncInstanceModification): respect ancestor during startBefore/after cmd execution #4829
+380
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…fter cmd execution related to #4507
PHWaechtler
force-pushed
the
4507-startafter-startbefore-ignore-ancestor-field
branch
from
45ea27d
to
30a3ea4
Compare
PHWaechtler
commented
Dec 3, 2024
Comment on lines
+89
to
+95
| public String getAncestorActivityInstanceId() { | ||
| return ancestorActivityInstanceId; | ||
| } | ||
|
|
||
| public void setAncestorActivityInstanceId(String ancestorActivityInstanceId) { | ||
| this.ancestorActivityInstanceId = ancestorActivityInstanceId; | ||
| } |
There was a problem hiding this comment.
Q:
I noticed this ancestorID field also exists in TransitionInstantiationCmd and it is also not set during serialization and deserialistion of this command. I had a look at some of the tests for TransitionInstantiationCmd, but I do not have enough context for how this command is used by the user and what the expected behaviour is to be able to judge if the same issue exists here. I also saw no support tickets with an edge case for this specific command.
Suggestion:
I open a follow up ticket for further investigation and potential fix of TransitionInstantiationCmd (if required).
Wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4507