Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Camunda 8 Forms #3952

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Deploy Camunda 8 Forms #3952

merged 5 commits into from
Nov 6, 2023

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Oct 30, 2023

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 30, 2023
@philippfromme philippfromme changed the title 3656 deploy forms Deploy Camunda 8 Forms Oct 30, 2023
@philippfromme philippfromme force-pushed the 3656-deploy-forms branch 3 times, most recently from 59d8396 to 90bef37 Compare October 31, 2023 14:16
@philippfromme
Copy link
Contributor Author

Depends on camunda-community-hub/zeebe-client-node-js#338 to be integrated.

@philippfromme philippfromme marked this pull request as ready for review November 6, 2023 08:47
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 6, 2023
@nikku
Copy link
Member

nikku commented Nov 6, 2023

Integrated zeebe-node via 2e75d7e.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works for me.

👍 for cleaning up on the way 🙂

@marstamm
Copy link
Member

marstamm commented Nov 6, 2023

I found a related issue when setting form-id in the properties panel
#3963

@marstamm
Copy link
Member

marstamm commented Nov 6, 2023

I can deploy forms to an 8.3.1 SaaS cluster (so the modeler part works), but Tasklist does not seem to pick it up. Is this expected? Is there an easy way to test it end to end?

@nikku
Copy link
Member

nikku commented Nov 6, 2023

I can deploy forms to an 8.3.1 SaaS cluster (so the modeler part works), but Tasklist does not seem to pick it up. Is this expected? Is there an easy way to test it end to end?

I'd verify two things:

  • Is it deployed according to zeebe ➡️ check deployed resources
  • Are we running into the "tasklist idle timeout" trap?

@philippfromme
Copy link
Contributor Author

Fix for #3963: bpmn-io/bpmn-js-properties-panel#998

@marstamm
Copy link
Member

marstamm commented Nov 6, 2023

I'd verify two things:

  • Is it deployed according to zeebe ➡️ check deployed resources
  • Are we running into the "tasklist idle timeout" trap?

I am running into problems in the first step: Where can we even check deployed resources? Console does not show it, Operate only shows Processes (and Decision INSTANCES, no definitions), Tasklist shows Tasks and process Definitions. zbctl does not seem to have a "list" method either.

Am I missing something?

@nikku
Copy link
Member

nikku commented Nov 6, 2023

@marstamm It looks to me as if tasklist does not support deployments yet, it will come with the next alpha (https://github.com/camunda/tasklist/issues/3463).

Copy link
Member

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that makes sense then. Just wanted to clarify if this was expected, and it seems that it is :)

@nikku
Copy link
Member

nikku commented Nov 6, 2023

Tasklist shows Tasks and process Definitions. zbctl does not seem to have a "list" method either.

We indeed need to trust the response we get from zeebe-node for the time being.

@nikku nikku merged commit 70a4204 into develop Nov 6, 2023
12 checks passed
@nikku nikku deleted the 3656-deploy-forms branch November 6, 2023 13:26
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 6, 2023
@nikku nikku added this to the M70 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants