fix: unauthenticated external elasticsearch no longer forces password… #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to be configured
|
This change doesn't work, as it is. turns out our |
|
I found a solution to this one by writing a function that is effectively boolean, just leveraging whether a string is empty or nonempty. |
drodriguez-305
approved these changes
Jun 17, 2024
aabouzaid
added
the
version:10.2.0
This was referenced Jul 2, 2024
Closed
aabouzaid
pushed a commit
that referenced
this pull request
Jul 13, 2024
#1990) * fix: unauthenticated external elasticsearch no longer forces passwords to be configured * fix: fixup boolean expression * test: adds operate tests for elasticsearch auth disabled
This was referenced Jul 13, 2024
Closed
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s to be configured
Which problem does the PR fix?
#1987
Currently external elasticsearch servers that do not require authentication, results in a camunda helm installation with
CreateContainerConfigErrordue our helm chart thinking that credentials exist, when they do not.What's in this PR?
For each deployment or statefulset, if there is no password defined for elasticsearch, then the env vars supplying those passwords will no longer be rendered.
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: