ci: adding workflow for pr conventions #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamza-m-masood
changed the title
auto-merge was automatically disabled
July 2, 2024 16:30
Pull request was closed
hamza-m-masood
force-pushed
the
pr-conventions
branch
from
1b7ef65
to
881b27a
Compare
|
Interestingly when I only ahve one commit I get this error: |
hamza-m-masood
force-pushed
the
pr-conventions
branch
from
1756f23
to
b7fc916
Compare
aabouzaid
reviewed
Jul 2, 2024
| @@ -0,0 +1,34 @@ | |||
| name: Pull Request Conventions | |||
There was a problem hiding this comment.
Following the same convention let's call it Repo - Pull Request Conventions
6 tasks
aabouzaid
pushed a commit
that referenced
this pull request
Jul 13, 2024
* ci: adding workflow for pr conventions
aabouzaid
pushed a commit
that referenced
this pull request
Jul 13, 2024
* ci: adding workflow for pr conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
related: #1581
What's in this PR?
Enforcing PR conventions
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: