Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): failure alerts are not triggered on ROSA schedule integration #2117

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

leiicamundi
Copy link
Contributor

Which problem does the PR fix?

What's in this PR?

This fix implements the same logic as we have in
https://github.com/camunda/camunda-tf-eks-module/blob/85f9a6913e3a14c0c0ce966e9dc434762e1448b2/.github/workflows/tests.yml#L184

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@leiicamundi leiicamundi self-assigned this Jul 5, 2024
@leiicamundi leiicamundi added kind/bug Something isn't working as intended area/ci labels Jul 5, 2024
@leiicamundi leiicamundi marked this pull request as ready for review July 5, 2024 06:10
@aabouzaid
Copy link
Member

LGTM, thank you 👍

@aabouzaid aabouzaid merged commit fa445d0 into main Jul 5, 2024
19 of 25 checks passed
@aabouzaid aabouzaid deleted the fix/alerts-on-failure branch July 5, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci kind/bug Something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants