Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): refactor rosa integration test workflow #2118

Merged
merged 5 commits into from
Jul 13, 2024

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Jul 5, 2024

What's in this PR?

Using the integration test as a GitHub action instead of a GitHub workflow reduced the readability of it.
So, I reverted it to use GitHub workflow and updated the ROSA integration test accordingly.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch from 0cff304 to b95a558 Compare July 5, 2024 16:10
Signed-off-by: Ahmed AbouZaid <[email protected]>
@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch 9 times, most recently from f052d3b to 08ed1d8 Compare July 6, 2024 09:37
@aabouzaid aabouzaid changed the title chore: tidy up integration test workflow. chore: tidy up integration test workflow Jul 6, 2024
@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch 4 times, most recently from 97df3a4 to dda3e83 Compare July 6, 2024 21:23
Signed-off-by: Ahmed AbouZaid <[email protected]>
@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch 13 times, most recently from 9f6c484 to c46459d Compare July 7, 2024 00:36
@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch 16 times, most recently from 934b30b to d531594 Compare July 8, 2024 02:53
Signed-off-by: Ahmed AbouZaid <[email protected]>
@aabouzaid aabouzaid force-pushed the medic-aa-chart-test-workflow branch from d531594 to 47b6946 Compare July 8, 2024 08:04
@aabouzaid aabouzaid self-assigned this Jul 13, 2024
@aabouzaid aabouzaid changed the title chore: tidy up integration test workflow chore(ci): refactor rosa integration test workflow Jul 13, 2024
@aabouzaid aabouzaid added size/s Relative effort/time: Small kind/refactor area/ci kind/medic Tasks for the medic labels Jul 13, 2024
@aabouzaid aabouzaid marked this pull request as ready for review July 13, 2024 22:13
@aabouzaid aabouzaid merged commit 67facb1 into main Jul 13, 2024
32 checks passed
@aabouzaid aabouzaid deleted the medic-aa-chart-test-workflow branch July 13, 2024 22:14
aabouzaid added a commit that referenced this pull request Jul 13, 2024
aabouzaid added a commit that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci kind/medic Tasks for the medic kind/refactor size/s Relative effort/time: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant