fix: only create one CREATED event per form on distribution #25728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon deployment CREATE distribution, we only create one CREATED event per form with the defined resource content per partition. We use the checksum to identify the unqiue form resources instead of relying on resource names as those can occur multiple times per deployment. Otherwise, we are creating too many CREATED events for each form resource, one for each other form with the same name and the content of that other form. This can lead to forms having the wrong content in the end, depending on which event was processed last for a form.
Ensures forms are only deployed once per partition with their defined content on deployment distribution, even when there are multiple forms with the same name in one deployment.
tmetzke
added
backport stable/8.3
remcowesterhoud
approved these changes
Dec 9, 2024
|
Successfully created backport PR for |
|
Successfully created backport PR for
|
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-actions
bot
added
version:8.3.19
version:8.5.11
version:8.4.15
version:8.6.7
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon deployment CREATE distribution, we only create one CREATED event per form with the defined
resource content per partition. We use the checksum to identify the unqiue form resources instead
of relying on resource names as those can occur multiple times per deployment.
Otherwise, we are creating too many CREATED events for each form resource, one for each other form
with the same name and the content of that other form. This can lead to forms having the wrong
content in the end, depending on which event was processed last for a form.
Checklist
Related issues
closes #25727