Don't re-load a Manifest's optional external resource each time if initial failed #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it would also be present on v3 and is very simple. So if/when merged, I'll backport this to v3 |
peaBerberian
added
Priority: 1 (High)
Florent-Bouisset
approved these changes
Feb 1, 2024
…itial failed While doing some testing on `<UTCTiming>` elements in a DASH MPD, it has been brought to us that if attempts to load an URL linked to it for the initial fetch of the Manifest failed (in which case we fallback to a mode where we don't rely on that element) and if the Manifest has to be refreshed multiple times, then the URL will be accessed every time the Manifest is refreshed, even if just one sucessful attempt would be enough. The issue was very simple to fix, as it was just that a newly obtained `clockOffset` - the actual metadata derived from parsing an `<UTCTiming>` element, was just not actually copied when updating the base Manifest by its new parsed version. Once that `clockOffset` is set to the base Manifest, that information will be communicated to our Manifest parser when refreshed, so it won't retry to load the clock and continue relying on the one fetched before.
peaBerberian
force-pushed
the
fix/update-clock-offset
branch
from
e75e8d5 to
650f7d8
Compare
peaBerberian
added a commit
that referenced
this pull request
Feb 5, 2024
Don't re-load a Manifest's optional external resource each time if initial failed
peaBerberian
added a commit
that referenced
this pull request
Feb 5, 2024
Don't re-load a Manifest's optional external resource each time if initial failed
Merged
peaBerberian
added a commit
that referenced
this pull request
Feb 5, 2024
Don't re-load a Manifest's optional external resource each time if initial failed
peaBerberian
added a commit
that referenced
this pull request
Feb 20, 2024
Don't re-load a Manifest's optional external resource each time if initial failed
peaBerberian
added a commit
that referenced
this pull request
Feb 20, 2024
Don't re-load a Manifest's optional external resource each time if initial failed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some testing on
<UTCTiming>elements in a DASH MPD, it has been brought to us that if all attempts to load its linked URL failed for the initial fetch of the Manifest (in which case we fallback to a mode where we don't rely on that element) and if the Manifest has to be refreshed multiple times, then the URL will be accessed every time the Manifest is refreshed, even if just one sucessful attempt would have been enough.The issue was very simple to fix, as it was just that a newly obtained
clockOffset- the actual metadata derived from parsing an<UTCTiming>element, was not actually copied when updating the base Manifest by its new parsed version.Once that
clockOffsetis set to the base Manifest, that information will be communicated to our Manifest parser when the Manifest is refreshed, so it won't retry to load the clock and continue relying on the one fetched before.