[Proposal] Remove standalone demo #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
Demo
peaBerberian
force-pushed
the
misc/remove-standalone-demo
branch
from
7cc5110 to
a22905f
Compare
Florent-Bouisset
approved these changes
Jul 9, 2024
The RxPlayer historically proposed two demo:
- The "full" demo, containing a whole application relying on the
RxPlayer to load content. Which also corresponds to our advertised
RxPlayer demo page on github: https://developers.canal-plus.com/rx-player/
- The "standalone" demo, which is just an HTML page containing a default
RxPlayer bundle script and a video element, allowing to perform
playback tests through the console.
We never really relied on the standalone demo, any kind of test we
perform being on any case either on the full demo, or directly linked to
final applications developped internally at Canal+.
Consequently to simplify the repository maintainance, I propose here to
remove the standalone demo and to move the full demo from the
`demo/full` directory to just `demo/`.
peaBerberian
force-pushed
the
misc/remove-standalone-demo
branch
from
a22905f to
9ed6e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RxPlayer historically proposed two demos:
The "full" demo, containing a whole application relying on the RxPlayer to load content. Which also corresponds to our advertised RxPlayer demo page on github: https://developers.canal-plus.com/rx-player/
The "standalone" demo, which is just an HTML page containing a default RxPlayer bundle script and a video element, allowing to perform playback tests through the console.
We never really relied on the standalone demo, any kind of test we perform being on any case either on the full demo, or directly linked to final applications developed internally at Canal+.
Consequently to simplify the repository maintenance, I propose here to remove the standalone demo and to move the full demo from the
demo/fulldirectory to justdemo/.