-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Calico CNI images from upstream #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also needs
k8s-snap/src/k8s/pkg/k8sd/features/calico/register.go
Lines 13 to 36 in 2e29d06
// TODO: configurable Calico images, include in this list | |
// | |
// Hardcoded list based on "k8s kubectl get node -o template='{{ range .items }}{{ .metadata.name }}{{":"}}{{ range .status.images }}{{ "\n- " }}{{ index .names 1 }}{{ end }}{{"\n"}}{{ end }}' | grep calico": | |
// | |
// - docker.io/calico/node:v3.28.0 | |
// - docker.io/calico/cni:v3.28.0 | |
// - docker.io/calico/apiserver:v3.28.0 | |
// - docker.io/calico/kube-controllers:v3.28.0 | |
// - docker.io/calico/typha:v3.28.0 | |
// - docker.io/calico/node-driver-registrar:v3.28.0 | |
// - docker.io/calico/csi:v3.28.0 | |
// - docker.io/calico/pod2daemon-flexvol:v3.28.0 | |
images.Register( | |
"docker.io/calico/node:v3.28.0", | |
"docker.io/calico/cni:v3.28.0", | |
"docker.io/calico/apiserver:v3.28.0", | |
"docker.io/calico/kube-controllers:v3.28.0", | |
"docker.io/calico/typha:v3.28.0", | |
"docker.io/calico/node-driver-registrar:v3.28.0", | |
"docker.io/calico/csi:v3.28.0", | |
"docker.io/calico/pod2daemon-flexvol:v3.28.0", | |
) |
I have checked and all the images are already in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comment and we're good to go! Nice work!
Overview
Sync Calico CNI images from upstream to the ghcr.io registry.
Rationale
We have encountered that we hit the rate limits of DockerHub. This pull request mirrors the images we are using in Calico to ghcr.io, allowing the k8s snap to pull them from there instead of DockerHub.
Testing