-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Worker Certificates Renewal Endpoints #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @mateoflorido
Added a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass. Good work overall, but see the requested changes
e5111ec
to
15e1b3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments, great work @mateoflorido !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final comments about the watcher restarts. It's OK to ignore the comment to start with and just a leave a NOTE if it becomes a problem in the future, rather than having huge functions, as they come with very big cyclomatic complexity
ec6d809
to
b740591
Compare
Overview
Implement the required endpoints for refreshing certificates for Kubernetes worker nodes.
Rationale
As stated in Proposal 002. We need to provide two endpoints to allow certificates refreshes in the cluster. This pull request implements the
refresh-certs/plan
and therefresh-certs/run
for refreshing the worker nodes' certificates.Testing
This pull request has been tested manually. Automated testing will be added in a future pull request.