Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPv6-only on IPv6 only infra test #768

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Nov 5, 2024

Initially, those tests were skipped on main because of Cilium LB limitations. We now moved to Metallb for this and therefore can enable it everywhere.

Note that we also remove the test_ipv6_on_ipv6_only_infra because of limitations on the github runners: actions/runner-images#668

Initially, those tests were skipped on main because of Cilium LB
limitations. We now moved to Metallb for this and therefore can enable
it everywhere.
@bschimke95 bschimke95 requested a review from a team as a code owner November 5, 2024 09:29
Copy link
Member

@berkayoz berkayoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschimke95
Copy link
Contributor Author

seems like snap has some issues with IPv6-only LXD containers on 24.04. I'll investigate.

@bschimke95 bschimke95 changed the title Enable IPv6 tests on main branch Remove IPv6-only on IPv6 only infra test Nov 8, 2024
@bschimke95
Copy link
Contributor Author

Turned out that the issue was not 24.04 but rather the ipv6 connectivity, which we cannot support on the runners: actions/runner-images#668

This only popped up on 24.04 because on the previous versions core20 is already shipped with the image. This is a requirement for the k8s snap and it failed to fetch it due to missing connectivity.

@bschimke95 bschimke95 merged commit 92828c5 into main Nov 8, 2024
15 of 19 checks passed
@bschimke95 bschimke95 deleted the bschimke95/enable-ipv6-tests-on-main branch November 8, 2024 14:51
evilnick pushed a commit to evilnick/k8s-snap that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants