Checks k8s-related port availability in PreInitChecks #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please address this comment: #815 (comment) |
Done |
PreInitChecks is called on bootstrap or when joining another Kubernetes cluster. Kubernetes and its services open up several ports; if they're already in use, we cannot progress. Adding these checks will make these error cases more explainable to the user, rather than a generic bootstrap / join error.
Previously, we've only checked if the default Kubernetes service prots are open. However, they can be changed, or disabled, which we did not take into account. With this, we will.
Trying to listen on the given port will instead allow us to check against all addresses.
claudiubelu
force-pushed
the
KU-2198/preinit-check-k8s-ports
branch
from
a423fc8 to
b97b1b2
Compare
berkayoz
reviewed
Dec 2, 2024
claudiubelu
force-pushed
the
KU-2198/preinit-check-k8s-ports
branch
from
bd7307e to
2fc0484
Compare
claudiubelu
force-pushed
the
KU-2198/preinit-check-k8s-ports
branch
from
2fc0484 to
3b34268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreInitChecksis called on bootstrap or when joining another Kubernetes cluster. Kubernetes and its services open up several ports; if they're already in use, we cannot progress.Adding these checks will make these error cases more explainable to the user, rather than a generic bootstrap / join error.
Sample error: