Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading explanation page #950

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Conversation

nhennigan
Copy link
Contributor

Explanation page that covers both snap and charm upgrades so {include} statement used to duplicate the page in both locations

@nhennigan nhennigan requested a review from a team as a code owner January 10, 2025 23:07
bschimke95
bschimke95 previously approved these changes Jan 13, 2025
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, got some minor comments.

docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
@bschimke95 bschimke95 dismissed their stale review January 13, 2025 09:27

found some comments to address

docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I approved it by accident

Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @nhennigan! I've left you some suggestions:

docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
docs/src/snap/explanation/upgrade.md Outdated Show resolved Hide resolved
Explanation page that covers both snap and charm upgrades so {include} statement used to duplicate the page in both locations
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, final approval from @mateoflorido - then we can merge this.

Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks @nhennigan!

@nhennigan nhennigan merged commit 5a7cca2 into canonical:main Jan 17, 2025
5 checks passed
@nhennigan nhennigan deleted the KU-235-upgrade-exp branch January 29, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants