Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix snap storage #985

Merged
merged 2 commits into from
Jan 17, 2025
Merged

docs: Fix snap storage #985

merged 2 commits into from
Jan 17, 2025

Conversation

mateoflorido
Copy link
Member

Overview

Include documentation updates for the snap storage guides.

@mateoflorido mateoflorido requested a review from a team as a code owner January 17, 2025 18:55
Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick thing, Perk mentioned that storage is now enabled by default in the storage.md file so can we update that with this PR also?

"clusterID": "fsid 6d5c12c9-6dfb-445a-940f-301aa7de0f29",
"clusterID": "6d5c12c9-6dfb-445a-940f-301aa7de0f29",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a copy error, you should place the fsid value you got earlier in the clusterID value. More info: https://docs.ceph.com/en/latest/rbd/rbd-kubernetes/

Copy link
Contributor

@nhennigan nhennigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateoflorido mateoflorido merged commit 732c0ca into main Jan 17, 2025
6 checks passed
@mateoflorido mateoflorido deleted the m/fix-snap-storage branch January 17, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants