Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(daemon): improve test coverage of notices API #346

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

olivercalder
Copy link
Member

Improve the test coverage of the notices API, and on the behavior of per-user notices in particular.

This is a backport of a fix from the snapd port of pebble notices. The original commit can be found at:

canonical/snapd@027ae88

This is a backport of a fix from the snapd port of pebble notices.
The original commit can be found at:

canonical/snapd@027ae88

Signed-off-by: Oliver Calder <[email protected]>
Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks! Given this is just test additions, I'll merge this now without further review.

@benhoyt benhoyt merged commit df7277e into canonical:master Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants